linux-kernel - Re: [PATCH] eeepc-laptop.c: use pr_fmt and pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A28F94A.6040500@tuffmail.co.uk>
Date:	Fri, 05 Jun 2009 11:54:02 +0100
From:	Alan Jenkins <alan-jenkins@...fmail.co.uk>
To:	Joe Perches <joe@...ches.com>
CC:	acpi4asus-user@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>,
	Len Brown <len.brown@...el.com>,
	Corentin Chary <corentincj@...aif.net>,
	Matthew Garrett <mjg@...hat.com>,
	Darren Salt <linux@...mustbejoking.demon.co.uk>
Subject: Re: [PATCH] eeepc-laptop.c: use pr_fmt and pr_<level>

Joe Perches wrote:
> Convert the unusual printk(EEEPC_<level> uses to
> the more standard pr_fmt and pr_<level>(.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
>
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 353a898..94cacdd 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -16,6 +16,8 @@
>   *  GNU General Public License for more details.
>   */
>  
> +#define pr_fmt(fmt) EEEPC_HOTK_FILE ": " fmt
>
>   

Is EEEPC_HOTK_FILE used anywhere else?  It would be clearer if you were 
able to just use "eeepc: " or whatever and remove the definition of 
EEEPC_HOTK_FILE.

Thanks for the cleanup
Alan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/