linux-kernel - Re: [PATCH] eeepc-laptop: enable camera by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71cd59b00906050602s5c9b9a31ne11b6aaf7546f58c@mail.gmail.com>
Date:	Fri, 5 Jun 2009 15:02:28 +0200
From:	Corentin Chary <corentin.chary@...il.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	acpi4asus-user@...ts.sourceforge.net, len.brown@...el.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eeepc-laptop: enable camera by default

On Fri, Jun 5, 2009 at 2:44 PM, Pekka Enberg<penberg@...helsinki.fi> wrote:
> Hi Corentin,
>
> On Fri, 2009-06-05 at 13:46 +0200, Corentin Chary wrote:
>> First, I think a one line
>> set_acpi(CM_ASL_CAMERA, 1);
>> with a small comment is better. (If it fails, it's because there no
>> camera, so we don't mind).
>
> OK, I've included an updated version of the patch.
>
> On Fri, 2009-06-05 at 13:46 +0200, Corentin Chary wrote:
>> Anyway, I'm not sure it's a good idea to enable the camera by default.
>> It depends how many power the camera is using (when idle). Coud you
>> check that (with power top maybe ?).
>
> People who prefer power savings over functional camera can always
> disable it. If you look at the amount of "my camera doesn't" work bug
> reports, I think it's pretty evident that we should enable it by default
> or provide a config option that does it.

Ok, your right, I'll apply that one

> That said, I am more than happy to measure this but I need a little bit
> more information to get started as I have never used powertop. So what
> is it exactly you want me to do?

PowerTop (with a corretly configured kernel) will give you a power
usage estimate.

CONFIG_NO_HZ=y
CONFIG_TIMER_STATS=y
CONFIG_DEBUG_KERNEL=y

For propers results, shutdown all services and just keep a shell
(without X or network).
You can also test that with and without the camera driver.

-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/