| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200906051558.02303.florian@openwrt.org> Date: Fri, 5 Jun 2009 15:58:01 +0200 From: Florian Fainelli <florian@...nwrt.org> To: matthieu castet <castet.matthieu@...e.fr> Cc: wim@...ana.be, Linux Kernel list <linux-kernel@...r.kernel.org>, linux-mips@...ux-mips.org, Aleksandar Radovanovic <biblbroks@...ampro.rs> Subject: Re: add bcm47xx watchdog driver Salut Matthieu, Le Thursday 04 June 2009 22:24:56 matthieu castet, vous avez écrit : > This add watchdog driver for broadcom 47xx device. > It uses the ssb subsytem to access embeded watchdog device. > > Because the watchdog timeout is very short (about 2s), a soft timer is used > to increase the watchdog period. > > Note : A patch for exporting the ssb_watchdog_timer_set will > be submitted on next linux-mips merge. Without this patch it can't > be build as a module. Your driver looks good, could you turn this into a platform device/driver instead ? You declare bcm47xx_wdt_platform_device which is unused and you also declare a MODULE_ALIAS which suggets it is one. You are also missing your name in both the header the the MODULE_AUTHOR macro. -- Best regards, Florian Fainelli Email : florian@...nwrt.org http://openwrt.org ------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists