linux-kernel - Re: [tip:perfcounters/core] perf report: Deal with maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090605150205.GQ7805@ghostprotocols.net>
Date:	Fri, 5 Jun 2009 12:02:05 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Ingo Molnar <mingo@...e.hu>, hpa@...or.com, paulus@...ba.org,
	linux-kernel@...r.kernel.org, efault@....de,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [tip:perfcounters/core] perf report: Deal with maps

Em Fri, Jun 05, 2009 at 04:06:24PM +0200, Peter Zijlstra escreveu:
> On Fri, 2009-06-05 at 10:57 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Jun 05, 2009 at 01:21:54PM +0000, tip-bot for Peter Zijlstra escreveu:
> > > Commit-ID:  fc54db5105d01ad691a7d747064c7890e17f936c
> > > Gitweb:     http://git.kernel.org/tip/fc54db5105d01ad691a7d747064c7890e17f936c
> > > Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > > AuthorDate: Fri, 5 Jun 2009 14:04:59 +0200
> > > Committer:  Ingo Molnar <mingo@...e.hu>
> > > CommitDate: Fri, 5 Jun 2009 14:46:41 +0200
> > > 
> > > perf report: Deal with maps
> > > 
> > > In order to deal with [vdso] maps generalize the ip->symbol path
> > > a bit and allow to override some bits with custom functions.
> > > 
> > > Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > > Cc: Mike Galbraith <efault@....de>
> > > Cc: Paul Mackerras <paulus@...ba.org>
> > > Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> > > LKML-Reference: <new-submission>
> > > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> > > 
> > > 
> > > ---
> > >  Documentation/perf_counter/builtin-report.c |   37 +++++++++++++++++++++++++-
> > >  Documentation/perf_counter/util/symbol.c    |    1 +
> > >  Documentation/perf_counter/util/symbol.h    |    1 +
> > >  3 files changed, 37 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/Documentation/perf_counter/builtin-report.c b/Documentation/perf_counter/builtin-report.c
> > > index eb5424f..9783d1e 100644
> > > --- a/Documentation/perf_counter/builtin-report.c
> > > +++ b/Documentation/perf_counter/builtin-report.c
> > > @@ -79,6 +79,7 @@ typedef union event_union {
> > >  
> > >  static LIST_HEAD(dsos);
> > >  static struct dso *kernel_dso;
> > > +static struct dso *vdso;
> > >  
> > >  static void dsos__add(struct dso *dso)
> > >  {
> > > @@ -136,6 +137,11 @@ static void dsos__fprintf(FILE *fp)
> > >  		dso__fprintf(pos, fp);
> > >  }
> > >  
> > > +static struct symbol *vdso__find_symbol(struct dso *dso, uint64_t ip)
> > > +{
> > > +	return dso__find_symbol(kernel_dso, ip);
> > > +}
> > 
> > Cut'n'paste error? s/kernel_dso/vdso/g
> 
> Ah, no, intentional cheating ;-)
> 
> the kernel dso includes the vdso symbols

OK, a comment would be nice then, will add it if you don't do it first :)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/