linux-kernel - Re: add bcm47xx watchdog driver v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A294E6E.4080209@free.fr>
Date:	Fri, 05 Jun 2009 18:57:18 +0200
From:	matthieu castet <castet.matthieu@...e.fr>
To:	Florian Fainelli <florian@...nwrt.org>
CC:	wim@...ana.be, Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-mips@...ux-mips.org,
	Aleksandar Radovanovic <biblbroks@...ampro.rs>
Subject: Re: add bcm47xx watchdog driver v2

Florian Fainelli wrote:
> Salut Matthieu,
> 
> Le Thursday 04 June 2009 22:24:56 matthieu castet, vous avez écrit :
>> This add watchdog driver for broadcom 47xx device.
>> It uses the ssb subsytem to access embeded watchdog device.
>>
>> Because the watchdog timeout is very short (about 2s), a soft timer is used
>> to increase the watchdog period.
>>
>> Note : A patch for exporting the ssb_watchdog_timer_set will
>> be submitted on next linux-mips merge. Without this patch it can't
>> be build as a module.
> 
> Your driver looks good, could you turn this into a platform device/driver 
> instead ? You declare bcm47xx_wdt_platform_device which is unused and you 
> also declare a MODULE_ALIAS which suggets it is one.
oops I attached the wrong patch.

This one should fix some build failure ;)

Matthieu

View attachment "bcm47xx_watchdog.diff" of type "text/x-diff" (8286 bytes)