linux-kernel - Re: [PATCH][mmtom] remove annotation of gfp_mask in add_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0906051858160.14826@sister.anvils>
Date:	Fri, 5 Jun 2009 19:03:52 +0100 (BST)
From:	Hugh Dickins <hugh.dickins@...cali.co.uk>
To:	Minchan Kim <minchan.kim@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	Hugh Dickins <hugh.dickins@...cali.co.uk>
Subject: Re: [PATCH][mmtom] remove annotation of gfp_mask in add_to_swap

On Fri, 5 Jun 2009, Minchan Kim wrote:

> Hugh removed add_to_swap's gfp_mask argument.
> (mm: remove gfp_mask from add_to_swap)
> So we have to remove annotation of gfp_mask  of the function.

"annotation"?  Or "DocBook comment"?  Or "DocBook annotation"?

> 
> This patch cleans up add_to_swap function.
> It doesn't affect behavior of function.
> 
> Signed-off-by: Minchan Kim <minchan.kim@...il.com>
> Cc: Hugh Dickins <hugh.dickins@...cali.co.uk>

Thanks, yes, my oversight.

Acked-by: Hugh Dickins <hugh.dickins@...cali.co.uk>

> ---
>  mm/swap_state.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/swap_state.c b/mm/swap_state.c
> index b9ca029..b62e7f5 100644
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -124,7 +124,6 @@ void __delete_from_swap_cache(struct page *page)
>  /**
>   * add_to_swap - allocate swap space for a page
>   * @page: page we want to move to swap
> - * @gfp_mask: memory allocation flags
>   *
>   * Allocate swap space for the page and add the page to the
>   * swap cache.  Caller needs to hold the page lock. 
> -- 
> 1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/