linux-kernel - Re: [PATCH 3/7] percpu: clean up percpu variable definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A289E3A.30000@kernel.org>
Date:	Fri, 05 Jun 2009 13:25:30 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
CC:	David Miller <davem@...emloft.net>, JBeulich@...ell.com,
	andi@...stfloor.org, mingo@...e.hu, hpa@...or.com,
	tglx@...utronix.de, linux-kernel@...r.kernel.org, x86@...nel.org,
	ink@...assic.park.msu.ru, rth@...ddle.net, linux@....linux.org.uk,
	hskinnemoen@...el.com, cooloney@...nel.org, starvik@...s.com,
	jesper.nilsson@...s.com, dhowells@...hat.com,
	ysato@...rs.sourceforge.jp, tony.luck@...el.com,
	takata@...ux-m32r.org, geert@...ux-m68k.org, monstr@...str.eu,
	ralf@...ux-mips.org, kyle@...artin.ca, paulus@...ba.org,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	lethal@...ux-sh.org, jdike@...toit.com, chris@...kel.net,
	rusty@...tcorp.com.au, jens.axboe@...cle.com, davej@...hat.com,
	jeremy@...source.com, linux-mm@...ck.org
Subject: Re: [PATCH 3/7] percpu: clean up percpu variable definitions

Benjamin Herrenschmidt wrote:
> On Mon, 2009-06-01 at 20:36 +0900, Tejun Heo wrote:
>>> Whether the volatile is actually needed or not, it's bad to have this
>>> kind of potential behavior changing nugget hidden in this seemingly
>>> inocuous change.  Especially if you're the poor soul who ends up
>>> having to debug it :-/
>> You're right.  Aieee... how do I feed volatile to the DEFINE macro.
>> I'll think of something.
> 
> Or better, work with the cris maintainer to figure out whether it's
> needed (it probably isn't) and have a pre-requisite patch that removes
> it before your series :-)

Yeap, that's worth giving a shot.

Mikael Starvik, can you please enlighten us why volatile is necessary
there?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/