[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 6 Jun 2009 14:35:18 -0700 (PDT)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Hugh Dickins <hugh.dickins@...cali.co.uk>
cc: Mimi Zohar <zohar@...ibm.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Mimi Zohar <zohar@...ux.vnet.ibm.com>,
Serge Hallyn <serue@...ibm.com>,
James Morris <jmorris@...ei.org>,
Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] integrity: fix IMA inode leak
On Sat, 6 Jun 2009, Linus Torvalds wrote:
>
> On Sat, 6 Jun 2009, Hugh Dickins wrote:
> >
> > CONFIG_IMA=y inode activity leaks iint_cache and radix_tree_node objects
> > until the system runs out of memory. Nowhere is calling ima_inode_free()
> > a.k.a. ima_iint_delete(). Fix that by calling it from destroy_inode().
>
> Shouldn't we call it from "security_inode_free()" instead? And shouldn't
> it be allocated in "security_inode_alloc()"? That sounds like the correct
> nesting here, since the whole integrity thing is under the security
> module.
>
> Hmm?
Oh well. I applied the patch as-is, since it seems to fix a real issue.
But I do think fs/inode.c shouldn't care about things like that, and have
it internal to security_inode_alloc/free(). But I guess that's a separate
cleanup.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists