linux-kernel - Re: [PATCH 1/7] initdev:kernel:Asynchronously-discovered device synchronization, v6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Jun 2009 10:43:18 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	David VomLehn <dvomlehn@...co.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-usb@...r.kernel.org, greg@...ah.com,
	linux-scsi@...r.kernel.org, netdev@...r.kernel.org,
	arjan@...radead.org
Subject: Re: [PATCH 1/7] initdev:kernel:Asynchronously-discovered device	synchronization,
 v6

David VomLehn wrote:
> +Some rules about correct usage:
> +o	Each call to initdev_found *must* be matched by a call to
> +	initdev_probe_done.

This would be useful as inline kerneldoc documentation at initdev_found().

> +o	The value of initdev_mask passed to initdev_found and
> +	initdev_probe_done for a given device must be identical.

And this as kerneldoc at initdev_probe_done().

What happens if the calls or the call arguments aren't balanced, e.g. 
due to a mistake in an error path?  The kernel will hang?

(BTW, much, though possibly not all, of the "History" section of your 
changelog should be below the --- delimiter, and the "v6" in the subject 
should be within the [PATCH ...] prefix.)
-- 
Stefan Richter
-=====-==--= -==- --==-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/