linux-kernel - Re: [PATCH]X86:microcode: fix vfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090607140113.GI12088@elte.hu>
Date:	Sun, 7 Jun 2009 16:01:13 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Figo.zhang" <figo1802@...il.com>,
	Dmitry Adamushko <dmitry.adamushko@...il.com>
Cc:	Andrew Morton <akpm@...l.org>,
	Tigran Aivazian <tigran@...itas.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]X86:microcode: fix vfree()


* Figo.zhang <figo1802@...il.com> wrote:

>  
> vfree() does it's own 'NULL' check,so no need for check before
> calling it.

looks good, but:

 s/it's/its/
 s/check,so/check, so/

and:

>  static void free_equiv_cpu_table(void)
>  {
> -	if (equiv_cpu_table) {
> -		vfree(equiv_cpu_table);
> -		equiv_cpu_table = NULL;
> -	}
> +	vfree(equiv_cpu_table);
> +	equiv_cpu_table = NULL;
> +	
>  }

stray newline and tab.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/