linux-kernel - Re: [PATCH RESEND]X86:microcode: fix vfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090607142819.GD21340@elte.hu>
Date:	Sun, 7 Jun 2009 16:28:19 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Figo.zhang" <figo1802@...il.com>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND]X86:microcode: fix vfree()


* Figo.zhang <figo1802@...il.com> wrote:

> On Sun, 2009-06-07 at 16:21 +0200, Ingo Molnar wrote:
> > (Note: it's not a 'resend', it's v2 of the patch)
> > 
> > * Figo.zhang <figo1802@...il.com> wrote:
> > 
> > > vfree() does its own 'NULL' check, so no need for check before
> > > calling it.
> > > 
> > > Signed-off-by: Figo.zhang <figo1802@...il.com>
> > > ---   
> > > arch/x86/kernel/microcode_amd.c |   13 +++++--------
> > >  1 files changed, 5 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
> > > index 453b579..8f52cf4 100644
> > > --- a/arch/x86/kernel/microcode_amd.c
> > > +++ b/arch/x86/kernel/microcode_amd.c
> > > @@ -257,10 +257,9 @@ static int install_equiv_cpu_table(const u8 *buf)
> > >  
> > >  static void free_equiv_cpu_table(void)
> > >  {
> > > -	if (equiv_cpu_table) {
> > > -		vfree(equiv_cpu_table);
> > > -		equiv_cpu_table = NULL;
> > > -	}
> > > +	vfree(equiv_cpu_table);
> > > +	equiv_cpu_table = NULL;
> > > +
> 
> i motify by vim, you said this line?

yes, that extra empty newline should not be there. (i.e. the line 
should be removed)
 
	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/