linux-kernel - Re: [git pull] IDE fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Jun 2009 16:57:49 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	James Bottomley <James.Bottomley@...senpartnership.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [git pull] IDE fixes

On Sunday 07 June 2009 16:38:56 James Bottomley wrote:
> On Sun, 2009-06-07 at 15:21 +0100, Alan Cox wrote:
> > > diff --git a/fs/partitions/check.c b/fs/partitions/check.c
> > > index 99e33ef..4bc2c43 100644
> > > --- a/fs/partitions/check.c
> > > +++ b/fs/partitions/check.c
> > 
> > 
> > You seriously want to add code to the core partition handling logic
> > moments before release when we know we have all sorts of devices with
> > weird behaviours ?
> > 
> > This should be .31 stuff where we can take the time to see how it works
> > on all sorts of weird real world devices (eg those with 2K sector size)
> > and the like.
> 
> Absolutely seconded.
> 
> Plus this is only one of the proposals for dealing with IDE native sizes
> moving through the process.  The other one is in libata with the gendisk
> proposal for alt size instead of your set_capacity callback.   The last

->set_capacity callback is needed for drivers/ide regardless of alt_size
sysfs interface and it don't conflict with it in any way.

Those patches are a complimentary work to Tejun's alt_size patches. 

They don't export anything to user-space.

> thing we want is two separate mechanisms for this, so trying to push
> anything upstream before we have agreement on direction is premature ...
> trying to send a feature as a bug fix is doubly so.

James, please (re-)read commits, then bug #13365 at kernel.org and if you
still find some code parts controversial I'll be happy to discuss them.

Thanks.
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/