linux-kernel - Re: [git pull] IDE fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0906071651250.6847@localhost.localdomain>
Date:	Sun, 7 Jun 2009 16:57:19 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
cc:	Pekka Enberg <penberg@...helsinki.fi>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [git pull] IDE fixes

On Mon, 8 Jun 2009, Bartlomiej Zolnierkiewicz wrote:
> 
> This is not a new feature and basing your opinions on opinions of people
> who don't read the code before commenting is bad, really bad, m'kay?

The thing is, I had planned on doing a final release yesterday, even 
before your pull came in. I decided to hold off, let it be, just to test 
the _current_ state a bit more. No way am I then adding some effectively 
totally untested new code-path.

And if you start messing in partitions.c and adding whole new callback 
functions to generic block_device_operations, then that's a new code-path. 
The IDE subsystem has _no_ business adding random new callbacks in 
the very last days of a release.

It sure as hell is not just a bugfix, it's a new feature. The feature may 
be _needed_ for some specific bug report, but that is totally irrelevant. 
We don't do things like that.

It's also almost certainly not a regression, is it? So by no measure does 
it work as a "late in the -rc sequence" patch.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/