linux-kernel - Re: [PATCH] kmemcheck: make bitfield annotations be valid C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090607092054.GA31286@elte.hu>
Date:	Sun, 7 Jun 2009 11:20:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Pekka Enberg <penberg@...helsinki.fi>,
	Vegard Nossum <vegard.nossum@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kmemcheck: make bitfield annotations be valid C


* Al Viro <viro@...IV.linux.org.uk> wrote:

> On Sat, May 16, 2009 at 09:40:08AM +0300, Pekka Enberg wrote:
> > On Fri, May 15, 2009 at 10:55 PM, Vegard Nossum <vegard.nossum@...il.com> wrote:
> > > From bb8926742d87da95aeb373bc2d4b35a554c5001b Mon Sep 17 00:00:00 2001
> > > From: Vegard Nossum <vegard.nossum@...il.com>
> > > Date: Fri, 15 May 2009 21:34:36 +0200
> > > Subject: [PATCH] kmemcheck: make bitfield annotations be valid C
> > >
> > > According to Al Viro, the syntax we were using (putting #ifdef inside
> > > macro arguments) was not valid C. He also suggested using begin/end
> > > markers instead, which is what we do now.
> > >
> > > Reported-by: Al Viro <viro@...iv.linux.org.uk>
> > > Signed-off-by: Vegard Nossum <vegard.nossum@...il.com>
> > 
> > Acked-by: Pekka Enberg <penberg@...helsinki.fi>
> > 
> > Al, are you okay with this?
> 
> Looks sane

Thanks.

This removes the blocker bug from kmemcheck and we can try to push 
it in the .31 merge window. Does the level and amount of bit-field 
annotations look unduly troublesome to you? If we merge kmemcheck 
then we'll have these type annotations forever.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/