linux-kernel - Re: [PATCH] x86, UV: Fix nacros for multiple coherency domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090608160324.GA4355@elte.hu>
Date:	Mon, 8 Jun 2009 18:03:24 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jack Steiner <steiner@....com>
Cc:	tglx@...utronix.de, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, UV: Fix nacros for multiple coherency domains


* Jack Steiner <steiner@....com> wrote:

> Fix bug in the SGI UV macros that support systems with multiple 
> coherency domains.  The macros used for referencing global MMR 
> (chipset registers) are failing to correctly "or" the NASID (node 
> identifier) bits that reside above M+N. These high bits are 
> supplied automatically by the chipset for memory accesses coming 
> from the processor socket. However, the bits must be present for 
> references to the special global MMR space used to map chipset 
> registers. (See uv_hub.h for more details ...)
> 
> The bug results in references to invalid/incorrect nodes.
> 
> Signed-off-by: Jack Steiner <steiner@....com>
> 
> ---
>  arch/x86/include/asm/uv/uv_hub.h   |    6 ++++--
>  arch/x86/kernel/apic/x2apic_uv_x.c |   15 +++++++++------
>  2 files changed, 13 insertions(+), 8 deletions(-)

Applied, thanks Jack. Note - this has missed .30 but i marked it for 
.30.1 backporting, because it obviously only affects UV code.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/