linux-kernel - Re: [PATCH][Updated] New AT91 MCI Driver that supports both MCI slots used at the same time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 8 Jun 2009 09:58:09 -0700
From:	Rob Emanuele <poorarm@...reis.com>
To:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Cc:	Joey Oravec <joravec@...wtech.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-kernel@...r.kernel.org,
	Haavard Skinnemoen <hskinnemoen@...el.com>
Subject: Re: [PATCH][Updated] New AT91 MCI Driver that supports both MCI slots 
	used at the same time

Hi Haavard,

I'd be happy to reintegrate my changes to this back into the Atmel
driver once I get it working correct on the at91.  Do you have the
equipment to give my changes a try?

Converting my #defines for the the features to cpu_is_xxx is easy
enough.  I'll take care of that.

Thanks,

Rob

On Mon, Jun 8, 2009 at 3:47 AM, Haavard
Skinnemoen<haavard.skinnemoen@...el.com> wrote:
> Rob Emanuele wrote:
>> This driver is a port the Atmel AVR32 MCI driver which uses similar silicon.
>
> While I do understand the motivation for this patch, I was kind of
> hoping we could reduce the number of drivers for the Atmel MCI
> hardware, not increase it...
>
> So I think it would be much better if your changes were integrated into
> one of the existing drivers.
>
>> Joey Oravec has mentioned that he has had better reliability with the chip
>> he is using (AT91SAM9261) if the MMC controller is reset before each
>> command.  There is a compile time option to do just that.
>
> This could be a useful option for atmel-mci too.
>
>> Joey Oravec has stated that the Read and Write Proof functionality that
>> prevents buffer overflows is not available on the AT91SAM9261.  This was
>> confirmed by Nicolas Ferre and also affects the AT91RM9200.  This new
>> patch excludes those register config bits.
>
> Preferably use the cpu_is_xxx() functions to achieve that. Perhaps even
> wrap those tests inside a mci_has_xxproof() function to make it
> clearer what you're testing for, and easier to change if we decide to
> do the test based on version registers, etc. later.
>
> Haavard
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/