linux-kernel - [PATCH] x86/x86_64: warn of -EBUSY returns from __assign_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090608173917.GA8264@us.ibm.com>
Date:	Mon, 8 Jun 2009 10:39:17 -0700
From:	Gary Hade <garyhade@...ibm.com>
To:	mingo@...e.hu, mingo@...hat.com
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de, hpa@...or.com,
	x86@...nel.org, ebiederm@...ssion.com, yinghai@...nel.org,
	suresh.b.siddha@...el.com, lcm@...ibm.com, garyhade@...ibm.com
Subject: [PATCH] x86/x86_64: warn of -EBUSY returns from
	__assign_irq_vector()


Impact: helps expose unexpected issues

Since we have seen one case where an unexpected -EBUSY
return from __assign_irq_vector() was included in the
series of events that caused a serious problem
  re: http://lkml.org/lkml/2009/6/2/377
we should warn to help expose similar unexpected issues
in the future.

Signed-off-by: Gary Hade <garyhade@...ibm.com>

---
 arch/x86/kernel/apic/io_apic.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: linux-2.6.30-rc8/arch/x86/kernel/apic/io_apic.c
===================================================================
--- linux-2.6.30-rc8.orig/arch/x86/kernel/apic/io_apic.c	2009-06-08 09:56:15.000000000 -0700
+++ linux-2.6.30-rc8/arch/x86/kernel/apic/io_apic.c	2009-06-08 09:56:27.000000000 -0700
@@ -1330,8 +1330,10 @@ __assign_irq_vector(int irq, struct irq_
 	int cpu, err;
 	cpumask_var_t tmp_mask;
 
-	if ((cfg->move_in_progress) || cfg->move_cleanup_count)
+	if ((cfg->move_in_progress) || cfg->move_cleanup_count) {
+		WARN_ON_ONCE(1);
 		return -EBUSY;
+	}
 
 	if (!alloc_cpumask_var(&tmp_mask, GFP_ATOMIC))
 		return -ENOMEM;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/