| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 08 Jun 2009 20:18:16 +0200 From: Stefan Richter <stefanr@...6.in-berlin.de> To: Pranith Kumar <pranith.hacks@...il.com> CC: greg@...ah.com, linux-kernel@...r.kernel.org, akpm@...l.org Subject: Re: [TRIVIAL][PATCH 1/1] Fix warning in staging/otus/ioctl.c I wrote: > However, the code which you looked > at also has other trivial deviations from kernel style. Notably, the > use of CamelCase names rather than all-lowercase with underscores. PS: Name changes are already at least one level more difficult than 1:1 type replacements, because giving _good_ names to variables/ functions etc. requires deeper understanding of what the code does. > if you are interested in doing that, then you can plan ahead and hold > off with whitespace adjusting changes (indentation, line wraps...) > until after you did those other changes But that's only an 'if'. If you rather only want to work on a single logical step for now, e.g. type replacement, then that's surely very welcome too. (My only concern about the "Fix warning..." was that making the warnings go away does not lead to actual improvements, or worse, covers up actual issues with the code. I.e. I didn't want to press you in to fixing those, just to take care _not_ to paper over them.) -- Stefan Richter -=====-==--= -==- -=--- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists