linux-kernel - Re: [this_cpu_xx 04/11] Use this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090608205406.GB13343@elte.hu>
Date:	Mon, 8 Jun 2009 22:54:06 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Christoph Lameter <cl@...ux-foundation.org>,
	Andy Whitcroft <apw@...onical.com>
Cc:	Robin Holt <holt@....com>, linux-kernel@...r.kernel.org,
	Tejun Heo <tj@...nel.org>, rusty@...tcorp.com.au,
	davem@...emloft.net
Subject: Re: [this_cpu_xx 04/11] Use this_cpu ops for network statistics


* Christoph Lameter <cl@...ux-foundation.org> wrote:

> On Mon, 8 Jun 2009, Robin Holt wrote:
> 
> > > +	this_cpu_inc((net)->ct.stat->count)
> >
> > Why not put this on one line?
> > #define NF_CT_STAT_INC_ATOMIC(net, count)  this_cpu_inc((net)->ct.stat->count)
> 
> Would be more than 78 characters in a line.

I think you can ignore such types of warnings in general. I think 
checkpatch should be silent up to 90 chars or so, if there's not 
more than say 3 tabs in that line. (if there's a lot of tabs that 
means the indentation level is wrong.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/