[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LFD.2.01.0906090940160.6847@localhost.localdomain>
Date: Tue, 9 Jun 2009 09:41:08 -0700 (PDT)
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Dave Jones <davej@...hat.com>
cc: Rusty Russell <rusty@...tcorp.com.au>,
Yinghai Lu <yinghai@...nel.org>, Avi Kivity <avi@...hat.com>,
Ingo Molnar <mingo@...e.hu>,
Andrew Morton <akpm@...ux-foundation.org>,
Thomas Gleixner <tglx@...utronix.de>,
"H. Peter Anvin" <hpa@...or.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
cpufreq@...r.kernel.org
Subject: Re: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of =
On Tue, 9 Jun 2009, Dave Jones wrote:
>
> work_on_cpu()'s definition could probably use a fat comment describing
> why it sucks.
No, it should be renamed.
The problem is that it _sounds_ like a nice thing to do.
If it was called "slow_other_cpu_thread_switch_with_a_donkey_on_top()", I
bet people wouldn't be so damn eager to use it.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists