linux-kernel - Re: [PATCH 04/27] score: create head files bitops.h bitsperlong.h bug.h bugs.h byteorder.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200906091850.58266.arnd@arndb.de>
Date:	Tue, 9 Jun 2009 18:50:57 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	liqin.chen@...plusct.com
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH 04/27] score: create head files bitops.h bitsperlong.h bug.h bugs.h byteorder.h

On Tuesday 09 June 2009, liqin.chen@...plusct.com wrote:

> diff --git a/arch/score/include/asm/bitops.h 
> b/arch/score/include/asm/bitops.h
> new file mode 100644
> index 0000000..2763b05
> --- /dev/null
> +++ b/arch/score/include/asm/bitops.h
> @@ -0,0 +1,16 @@
> +#ifndef _ASM_SCORE_BITOPS_H
> +#define _ASM_SCORE_BITOPS_H
> +
> +#include <asm/byteorder.h> /* swab32 */
> +#include <asm/system.h> /* save_flags */
> +
> +/*
> + * clear_bit() doesn't provide any barrier for the compiler.
> + */
> +#define smp_mb__before_clear_bit()     barrier()
> +#define smp_mb__after_clear_bit()      barrier()
> +
> +#include <asm-generic/bitops.h>
> +#include <asm-generic/bitops/__fls.h>
> +
> +#endif /* _ASM_SCORE_BITOPS_H */

I guess you tried using the asm-generic version of this file and
failed. Since you don't do anything architecture specific in
here, that could well mean that my version needs to be fixed.
What problem did you see?

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/