linux-kernel - Re: [PATCH 8/8] imx: serial: add IrDA support to serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090609180738.10014627@lxorguk.ukuu.org.uk>
Date:	Tue, 9 Jun 2009 18:07:38 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Oskar Schirmer" <os@...ix.com>
Cc:	Oskar Schirmer <os@...ix.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	linux-kernel@...r.kernel.org, Fabian Godehardt <fg@...ix.com>
Subject: Re: [PATCH 8/8] imx: serial: add IrDA support to serial driver

> Sure, the path will be optimized away, but still
> the conditional statement is subjected to syntax
> and scope analysis and gcc will correctly complain
> that irda_inv_rx is not declared.

Why are only about half of them done this way rather than all ?

> peripheral register settings, because the old baud rate
> calculation was not accurate enough for IrDA use.
> That's why we introduced the approximation function
> (and finally generalised it into lib/).

Yes - I'm fine with that part.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/