linux-kernel - Re: [RFC PATCH 1/1] smi_detector: A System Management Interrupt detector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090609145607.d8944778.akpm@linux-foundation.org>
Date:	Tue, 9 Jun 2009 14:56:07 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jon Masters <jonathan@...masters.org>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...e.hu,
	rostedt@...dmis.org
Subject: Re: [RFC PATCH 1/1] smi_detector: A System Management Interrupt
 detector

On Tue, 09 Jun 2009 17:50:01 -0400
Jon Masters <jonathan@...masters.org> wrote:

> > > +	if (0 != err)
> > 
> > 	if (err != 0)
> > 
> > or
> > 
> > 	if (err)
> > 
> > would be more typical.
> 
> The former runs the risk of assignment,

yup, which is why gcc will warn if you do

	if (err = 0)

If you really meant to do that, then gcc can be silenced by
double-parenthesising.  We consider this "good enough" for kernel
purposes, so we generally don't use the `if (CONSTANT == variable)' trick.


> whereas <value> != <variable>
> will generate a compiler error if it goes wrong, so I trained myself to
> always do that. The desired value is zero, so I prefer to show that in
> the test, but I have changed it following your advice anyway - it's like
> how I have to force myself not to use '{' '}' on single line
> if-statements despite generally doing so, again for safety :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/