linux-kernel - Re: [PATCH 4/8] tracing/events: modify irq print to new format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0906091846010.30552@gandalf.stny.rr.com>
Date:	Tue, 9 Jun 2009 18:46:50 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Minchan Kim <minchan.kim@...il.com>,
	Mel Gorman <mel@....ul.ie>,
	Christoph Hellwig <hch@...radead.org>,
	Rik van Riel <riel@...hat.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Peter Zijlstra <peterz@...radead.org>,
	Theodore Tso <tytso@....edu>,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Zhaolei <zhaolei@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Jason Baron <jbaron@...hat.com>,
	Jiaying Zhang <jiayingz@...gle.com>,
	Tom Zanussi <tzanussi@...il.com>
Subject: Re: [PATCH 4/8] tracing/events: modify irq print to new format


On Wed, 10 Jun 2009, Frederic Weisbecker wrote:
> >  
> >  /**
> > @@ -106,8 +106,8 @@ TRACE_EVENT(softirq_entry,
> >  		__entry->vec = (int)(h - vec);
> >  	),
> >  
> > -	TP_printk("softirq=%d action=%s", __entry->vec,
> > -		  show_softirq_name(__entry->vec))
> > +	TP_FORMAT("softirq=<int:vec> action=<sym:vec:" show_softirq_name_format(),
> 
> 
> Just to zap the confusion, I would suggest to explicitly close the '>' here instead
> of inside the macro. The current state suggests a kind of imbalance at a first glance.
> 
> 
> > +		  show_softirq_name_args())
> >  );
> >  
> >  /**
> > @@ -135,8 +135,8 @@ TRACE_EVENT(softirq_exit,
> >  		__entry->vec = (int)(h - vec);
> >  	),
> >  
> > -	TP_printk("softirq=%d action=%s", __entry->vec,
> > -		  show_softirq_name(__entry->vec))
> > +	TP_FORMAT("softirq=<int:vec> action=<sym:vec:" show_softirq_name_format(),
> 
> 
> And ditto.
> 

Ah, yeah right. Now that I have the formats separated, I can do that. The 
first patch had it as one (format and args). I'll add a separate patch in 
my next set of patches that build on top of this one.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/