linux-kernel - Re: [PATCH 4/6] x86/cpufreq: use cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2009 14:25:41 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Dave Jones <davej@...hat.com>, Yinghai Lu <yinghai@...nel.org>,
	Avi Kivity <avi@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	cpufreq@...r.kernel.org
Subject: Re: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of =

On Wed, 10 Jun 2009 02:11:08 am Linus Torvalds wrote:
> On Tue, 9 Jun 2009, Dave Jones wrote:
> > work_on_cpu()'s definition could probably use a fat comment describing
> > why it sucks.
>
> No, it should be renamed.
>
> The problem is that it _sounds_ like a nice thing to do.

Yeah, it used to be *faster* than the stupid mug-own-cpumask code it was 
supposed to replace.   Then we hit all those deadlocks using keventd, and 
revulsion against YA per-cpu thread, and ended up with the current sucky 
version.

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/