| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1244635716-23315-6-git-send-email-os@emlix.com> Date: Wed, 10 Jun 2009 14:08:32 +0200 From: "Oskar Schirmer" <os@...ix.com> To: Sascha Hauer <kernel@...gutronix.de> Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Alan Cox <alan@...rguk.ukuu.org.uk>, Oskar Schirmer <os@...ix.com>, Daniel Glöckner <dg@...ix.com> Subject: [PATCH 5/9 -v2] imx: serial: handle initialisation failure correctly From: Daniel Glöckner <dg@...ix.com> correctly de-initialise device when setting up failed, call to pdata->exit() was missing. Signed-off-by: Daniel Glöckner <dg@...ix.com> Signed-off-by: Oskar Schirmer <os@...ix.com> --- drivers/serial/imx.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c index 3fa07a9..60892a2 100644 --- a/drivers/serial/imx.c +++ b/drivers/serial/imx.c @@ -1155,10 +1155,15 @@ static int serial_imx_probe(struct platform_device *pdev) goto clkput; } - uart_add_one_port(&imx_reg, &sport->port); + ret = uart_add_one_port(&imx_reg, &sport->port); + if (ret) + goto deinit; platform_set_drvdata(pdev, &sport->port); return 0; +deinit: + if (pdata->exit) + pdata->exit(pdev); clkput: clk_put(sport->clk); clk_disable(sport->clk); -- 1.5.3.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists