linux-kernel - RE: [tip:tracing/core] x86, bts: reenable ptrace branch trace support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <928CFBE8E7CB0040959E56B4EA41A77EBBC6524F@irsmsx504.ger.corp.intel.com>
Date:	Wed, 10 Jun 2009 15:07:17 +0100
From:	"Metzger, Markus T" <markus.t.metzger@...el.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Ingo Molnar <mingo@...e.hu>, "mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"oleg@...hat.com" <oleg@...hat.com>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: RE: [tip:tracing/core] x86, bts: reenable ptrace branch trace
 support

>-----Original Message-----
>From: Peter Zijlstra [mailto:peterz@...radead.org]
>Sent: Wednesday, June 10, 2009 3:44 PM
>To: Metzger, Markus T
>Cc: Ingo Molnar; mingo@...hat.com; hpa@...or.com; linux-kernel@...r.kernel.org; tglx@...utronix.de;
>oleg@...hat.com; linux-tip-commits@...r.kernel.org
>Subject: RE: [tip:tracing/core] x86, bts: reenable ptrace branch trace support
>
>On Wed, 2009-06-10 at 14:32 +0100, Metzger, Markus T wrote:
>> >-----Original Message-----
>> >From: Peter Zijlstra [mailto:peterz@...radead.org]
>> >Sent: Wednesday, June 10, 2009 3:29 PM
>> >To: Metzger, Markus T
>> >Cc: Ingo Molnar; mingo@...hat.com; hpa@...or.com; linux-kernel@...r.kernel..org;
>tglx@...utronix.de;
>> >oleg@...hat.com; linux-tip-commits@...r.kernel.org
>> >Subject: RE: [tip:tracing/core] x86, bts: reenable ptrace branch trace support
>> >
>> >On Wed, 2009-06-10 at 14:22 +0100, Metzger, Markus T wrote:
>> >>
>> >> The Debug Store interface is completely in-kernel. It does not expose
>> >> anything to the outside world.
>> >>
>> >> What we expose is a ptrace interface for branch tracing.
>> >> That this is built on top of Debug Store is completely hidden.
>> >> The Debug Store interface may be changed without impacting the
>> >> user-visible part at any time.
>> >>
>> >> I do think that a ptrace interface makes sense since debuggers are the
>> >> targeted users for branch tracing.
>> >>
>> >> I don't see why we should not merge the fixes now and then rework the
>> >> in-kernel parts as needed for supporting PEBS.
>> >
>> >Ok, so what is all that account_locked_memory() for?
>>
>> To allow debuggers (users) to decide how much memory they want to spend
>> on branch tracing.
>
>But that is the debug store, right? User visible through some mlock
>accounting and limit.

Debug Store is the underlying implementation, that's all.

In the current implementation, we lock the entire buffer. In a future
implementation we might not need to lock the entire buffer, any more.
The only user-visible effect is that he will get -ENOMEM for bigger
buffers than today.


>Furthermore, it appears there is an interface for setting the size,
>that's also user visible and not fixable after the fact.

I don't see how that differs from setting the initial size.


>Once you want to multiplex cpu-wide and per task BTS/PEBS contexts,
>there is no choice but to view the DS as a cpu resource, not a task
>resource, therefore you cannot specify a size, nor attribute it to
>specific tasks mm accounting.

We can still attach a buffer to a task to hold the branch or pebs trace.
When can copy the trace from the limited cpu resource to that per-task buffer
when the Debug Store buffer overflows.

The accounting is done to have the tracer, i.e. the debugger, pay for the
system resources it uses.
If we later on decide to use a fixed-size statically allocated per-cpu
Debug Store buffer, the tracer would no longer need to pay for the
locked memory. It would still have to pay for the memory to hold the bigger
tracer buffer that the debugger requested.


regards,
markus.

---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/