linux-kernel - Re: [PATCH][GIT PULL] tracing: do not translate event helper macros in print format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 10 Jun 2009 22:48:02 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Minchan Kim <minchan.kim@...il.com>,
	Mel Gorman <mel@....ul.ie>, Rik van Riel <riel@...hat.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Peter Zijlstra <peterz@...radead.org>,
	Theodore Tso <tytso@....edu>,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Zhaolei <zhaolei@...fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Jason Baron <jbaron@...hat.com>,
	Jiaying Zhang <jiayingz@...gle.com>
Subject: Re: [PATCH][GIT PULL] tracing: do not translate event helper
	macros in print format


* Steven Rostedt <rostedt@...dmis.org> wrote:

> Ingo,
> 
> This looks like it changed more than it really did, I only moved 
> the one macro above another and added a few lines:
> 
>  +#undef __print_symbolic
>  +#undef __get_dynamic_array
>  +#undef __get_str
>  +
> 
> Please pull the latest tip/tracing/ftrace-1 tree, which can be found at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> tip/tracing/ftrace-1
> 
> 
> Steven Rostedt (1):
>       tracing: do not translate event helper macros in print format
> 
> ----
>  include/trace/ftrace.h |  158 ++++++++++++++++++++++++-----------------------
>  1 files changed, 81 insertions(+), 77 deletions(-)
> ---------------------------
> commit 6ff9a64d2aaa6eae396adc95e9c91c0cbfa6dbe4
> Author: Steven Rostedt <srostedt@...hat.com>
> Date:   Wed Jun 10 14:28:34 2009 -0400
> 
>     tracing: do not translate event helper macros in print format
>     
>     By moving the macro that creates the print format code above the
>     defining of the event macro helpers (__get_str, __print_symbolic,
>     and __get_dynamic_array), we get a little cleaner print format.
>     
>     Instead of:
>     
>       (char *)((void *)REC + REC->__data_loc_name)
>     
>     we get:
>     
>        __get_str(name)
>     
>     Instead of:
>     
>        ({ static const struct trace_print_flags symbols[] = { { HI_SOFTIRQ, "HI" }, {
>     
>     we get:
>     
>        __print_symbolic(REC->vec, { HI_SOFTIRQ, "HI" }, {

Yeah, that's really nice! Pulled, thanks Steve!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/