linux-kernel - Re: [PATCH 2/2] sched: use slab in cpupri

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A30B422.8080109@cn.fujitsu.com>
Date:	Thu, 11 Jun 2009 15:37:06 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
CC:	linux-kernel@...r.kernel.org, mingo@...e.hu,
	torvalds@...ux-foundation.org, yinghai@...nel.org
Subject: Re: [PATCH 2/2] sched: use slab in cpupri_init()

Pekka Enberg wrote:
> Hi Li!
> 
> On Thu, 2009-06-11 at 14:10 +0800, Li Zefan wrote:
>>> @@ -163,9 +167,7 @@ int __init_refok cpupri_init(struct cpupri *cp, bool bootmem)
>> so the __init_refok tag can be removed, no?
> 
> I am not sure how this is related to my patch but as long as
> init_rootdomain() has it, cpupri_init() should too AFAICT.
> 

cpupri_init() is marked as __init_refok, because it calls
alloc_bootmem_cpumask_var() not because init_rootdomain()
has the tag. Now this patch removes this function call,
so the tag is no long needed.

> 
>>>  
>>>  		spin_lock_init(&vec->lock);
>>>  		vec->count = 0;
>>> -		if (bootmem)
>>> -			alloc_bootmem_cpumask_var(&vec->mask);
>>> -		else if (!zalloc_cpumask_var(&vec->mask, GFP_KERNEL))
>>> +		if (!zalloc_cpumask_var(&vec->mask, gfp))
>>>  			goto cleanup;
>>>  	}
>>>  
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/