linux-kernel - RE: [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3A45394FD742FA419B760BB8D398F9ED483CCD@zch01exm26.fsl.freescale.net>
Date:	Thu, 11 Jun 2009 17:47:56 +0800
From:	"Li Yang-R58472" <LeoLi@...escale.com>
To:	"Kumar Gala" <galak@...nel.crashing.org>
Cc:	<akpm@...ux-foundation.org>, <davem@...emloft.net>,
	<mporter@...nel.crashing.org>, <linux-kernel@...r.kernel.org>,
	<linuxppc-dev@...abs.org>, <netdev@...r.kernel.org>,
	"Zhang Wei" <zw@...kernel.org>
Subject: RE: [PATCH 1/6] rapidio: add common mapping APIs for RapidIO memory access

>On May 12, 2009, at 3:35 AM, Li Yang wrote:
>
>> Add the mapping functions used to support direct IO memory access of 
>> rapidIO.
>>
>> Signed-off-by: Zhang Wei <zw@...kernel.org>
>> Signed-off-by: Li Yang <leoli@...escale.com>
>
>Use inbnd/outbnd instead of inb/outb which make one think of 
>byte level io accessors.
>
>As I look at this I don't think this is the correct API.  I 
>think we should be using the DMA mapping API to hide these 
>details.  The concept of mapping like this seems to be more a 
>function of FSL's Address translation/mapping unit (ATMU) than 
>anything specific to the RIO bus standard.

This is a separate RIO block level ATMU.  Although it looks like the
system level ATMU, system ATMU doesn't have the knowledge of rapidIO
target device ID.  The mapping need to be dynamic, as it's easy to have
more RIO devices than the outbound windows.

- Leo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/