linux-kernel - Re: [PATCH -tip] x86: perf_counter AMD supports performance monitoring for K7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090611001341.GA5631@elte.hu>
Date:	Thu, 11 Jun 2009 02:13:41 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86: perf_counter AMD supports performance
	monitoring for K7


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  arch/x86/kernel/cpu/perf_counter.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/perf_counter.c b/arch/x86/kernel/cpu/perf_counter.c
> index 240ca56..5d56742 100644
> --- a/arch/x86/kernel/cpu/perf_counter.c
> +++ b/arch/x86/kernel/cpu/perf_counter.c
> @@ -1436,6 +1436,10 @@ static int intel_pmu_init(void)
>  
>  static int amd_pmu_init(void)
>  {
> +	/* performance-monitoring supported from K7 */
> +	if (boot_cpu_data.x86 < 7)
> +		return -ENODEV;
> +
>  	x86_pmu = amd_pmu;
>  
>  	switch (boot_cpu_data.x86) {

A commit under Linux consists of three parts:

  1) the title
  2) the changlog
  3) the body

This sloppy patch of yours manages to get _all_ three wrong:

  - the title is wrong (it is incorrect)
  - the changelog is wrong (it is missing)
  - the body is wrong (it is broken - K7 != family 7)

What the heck is going on here?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/