linux-kernel - Re: [PATCH] partitions: fix broken uevent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 11 Jun 2009 21:23:51 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Greg KH <gregkh@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] partitions: fix broken uevent_suppress conversion

2009/6/11 Heiko Carstens <heiko.carstens@...ibm.com>:
> From: Heiko Carstens <heiko.carstens@...ibm.com>
>
> git commit f67f129e "Driver core: implement uevent suppress in kobject"
> contains this chunk for fs/partitions/check.c:
>
>        /* suppress uevent if the disk supresses it */
> -       if (!ddev->uevent_suppress)
> +       if (!dev_get_uevent_suppress(pdev))
>                kobject_uevent(&pdev->kobj, KOBJ_ADD);
>
> However that should have been
>
> -       if (!ddev->uevent_suppress)
> +       if (!dev_get_uevent_suppress(ddev))
>
> Cc: Ming Lei <tom.leiming@...il.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
>  fs/partitions/check.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/fs/partitions/check.c
> ===================================================================
> --- linux-2.6.orig/fs/partitions/check.c
> +++ linux-2.6/fs/partitions/check.c
> @@ -426,7 +426,7 @@ struct hd_struct *add_partition(struct g
>        rcu_assign_pointer(ptbl->part[partno], p);
>
>        /* suppress uevent if the disk supresses it */
> -       if (!dev_get_uevent_suppress(pdev))
> +       if (!dev_get_uevent_suppress(ddev))
>                kobject_uevent(&pdev->kobj, KOBJ_ADD);
>
>        return p;
>

Thanks.

Acked-by: Ming Lei <tom.leiming@...il.com>

-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/