linux-kernel - Re: [PATCH] Re:[BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m3d49btsfl.fsf@pobox.com>
Date:	Wed, 10 Jun 2009 21:28:30 -0500
From:	Nathan Lynch <ntl@...ox.com>
To:	subrata@...ux.vnet.ibm.com
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>, netdev@...r.kernel.org,
	Li Yang <leoli@...escale.com>,
	Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
	Linuxppc-dev <Linuxppc-dev@...abs.org>,
	Linux-Next <linux-next@...r.kernel.org>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>
Subject: Re: [PATCH] Re:[BUILD FAILURE 04/04] Next June 04:PPC64 randconfig
 [drivers/net/ucc_geth.o]

Subrata Modak <subrata@...ux.vnet.ibm.com> writes:

> On Thu, 2009-06-11 at 11:05 +1000, Stephen Rothwell wrote:
>> Hi Subrata,
>> 
>> On Wed, 10 Jun 2009 23:13:23 +0530 Subrata Modak <subrata@...ux.vnet.ibm.com> wrote:
>> >
>> >  	/* Find the TBI PHY.  If it's not there, we don't support SGMII */
>> > -	ph = of_get_property(np, "tbi-handle", NULL);
>> > +	ph = (phandle *)of_get_property(np, "tbi-handle", NULL);
>> 
>> You don't need this cast because of_get_property() returns "void *".
>
> Stephen,
>
> True. But without this gcc complains:
>
> CC [M]  drivers/net/ucc_geth.o
> drivers/net/ucc_geth.c: In function ‘ucc_geth_probe’:
> drivers/net/ucc_geth.c:3824: warning: assignment discards qualifiers
> from pointer target type

ph should be declared const phandle *.  Look at other uses of
of_get_property.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/