linux-kernel - Re: [PATCH 2/2] SLUB: Disable debugging if it increases the minimum page order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1244734086.17483.59.camel@penberg-laptop>
Date:	Thu, 11 Jun 2009 18:28:06 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Christoph Lameter <cl@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, mel@....ul.ie,
	Larry.Finger@...inger.net
Subject: Re: [PATCH 2/2] SLUB: Disable debugging if it increases the
 minimum page order

Hi Christoph,

On Thu, 11 Jun 2009, Pekka Enberg wrote:
> > I think my patch is the simplest solution here: it turns off debugging
> > for those caches where the metadata bumps up the minimum allocation
> > order and I suspect that we disable cache only for 4096 in practice.

On Thu, 2009-06-11 at 11:20 -0400, Christoph Lameter wrote:
> There could be other slab caches that would randomly be affected by this.
> I ran a couple of times into situations where I had to hack slab to do
> debugging of exempted slabs.

Yes, I do understand that and I have hit that too in the past. But
surely a printk() telling the user we disabled debugging can cure that?

My main point is that a lot of _testers_ will probably enable all SLUB
debugging by default because we encourage them to and it's pretty bad
that we end up causing order 1 allocations and oom conditions.

So I still think we need to fix _at minimum_ the kmalloc-4096 case
(assuming Larry won't hit the same problem still). I see you're not
happy with my patch so any suggestions how to handle that?

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/