linux-kernel - Re: [PATCH] init: introduce mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0906110854450.3573@localhost.localdomain>
Date:	Thu, 11 Jun 2009 08:56:51 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Pekka J Enberg <penberg@...helsinki.fi>
cc:	linux-kernel@...r.kernel.org, cl@...ux-foundation.org,
	mingo@...e.hu
Subject: Re: [PATCH] init: introduce mm_init()



On Thu, 11 Jun 2009, Pekka J Enberg wrote:
>  
> +static void __init mm_init(void)
> +{
> +	/*
> +	 * Set up kernel memory allocators
> +	 */
> +	mem_init();
> +	kmem_cache_init();
> +	vmalloc_init();
> +}

Please just put the comments at the top of the function in cases like 
this, ie just

	/*
	 * ...
	 */
	static int __init mm_init(void)
	{
		..
	}

also, I'm now terminally confused about the whole series, so I'm wondering 
if you could re-do the series so that (a) I have a clear picture of what 
to take, and (b) preferably so it's also all bisectable (ie the trap_init 
ordering fixes are done in the initial mm/init.c changes).

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/