[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4A314CB6.5090004@ru.mvista.com>
Date: Thu, 11 Jun 2009 22:28:06 +0400
From: Sergei Shtylyov <sshtylyov@...mvista.com>
To: Jeff Garzik <jgarzik@...ox.com>
Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
alan@...rguk.ukuu.org.uk
Subject: Re: [PATCH 2/2 resend] libata-sff: avoid byte swapping in ata_sff_data_xfer()
Hello.
Jeff Garzik wrote:
>> Hello, I wrote:
>>>> Handling of the trailing byte in ata_sff_data_xfer() is suboptimal
>>>> bacause:
>>>> - it always initializes the padding buffer to 0 which is not really
>>>> needed in
>>>> both the read and write cases;
>>>> - it has to use memcpy() to transfer a single byte from/to the
>>>> padding buffer;
>>>> - it uses io{read|write}16() accessors which swap bytes on the big
>>>> endian CPUs
>>>> and so have to additionally convert the data from/to the little
>>>> endian format
>>>> instead of using io{read|write}16_rep() accessors which are not
>>>> supposed to
>>>> change the byte ordering.
>>>>
>>>> Signed-off-by: Sergei Shtylyov <sshtylyov@...mvista.com>
>>> Jeff, have you forgotten about this one?
>> PING.
> This has been queued to libata-dev.git#upstream, i.e. linux-next queue,
Ah, haven't looked there, so it appeared as forgotten since I know you
usually reply with 'applied'.
> for a long time. Apologies if I forgot the 'applied' reply.
> Just sent this upstream, as linux-ide should show.
Thanks. I began to think of reworking it to avoid even io*_rep() as per
my followup mail and resending... well, it's good enogh as is. :-)
> Jeff
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists