linux-kernel - Re: [PATCH 2/6] cpumask: avoid playing with cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090611233125.GB32486@redhat.com>
Date:	Thu, 11 Jun 2009 19:31:25 -0400
From:	Dave Jones <davej@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	cpufreq@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>,
	Dominik Brodowski <linux@...do.de>
Subject: Re: [PATCH 2/6] cpumask: avoid playing with cpus_allowed in
	speedstep-ich.c

On Thu, Jun 11, 2009 at 10:59:58PM +0930, Rusty Russell wrote:


Minor nit (and this was there before your change, but because
you moved it, checkpatch now whines..)

 > +static void get_freqs_on_cpu(void *_get_freqs)
 > +{
 > +	struct get_freqs *get_freqs = _get_freqs;
 > +
 > +	get_freqs->ret =
 > +		speedstep_get_freqs(speedstep_processor,
 > +				    &speedstep_freqs[SPEEDSTEP_LOW].frequency,
 > +				    &speedstep_freqs[SPEEDSTEP_HIGH].frequency,
 > +				    &get_freqs->policy->cpuinfo.transition_latency,
 > +				    &speedstep_set_state);
 > +}

line over 80 characters. 
I'll just pull it back one tab.

Perhaps some variable renaming in this file is called for to reduce
some of the redundancy in such lines.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/