linux-kernel - Re: [PATCH] powerpc: don't pass GFP_WAIT to kmalloc() from *_maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1244799298.7172.108.camel@pasglop>
Date:	Fri, 12 Jun 2009 19:34:58 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	linux-kernel@...r.kernel.org, npiggin@...e.de, mingo@...e.hu
Subject: Re: [PATCH] powerpc: don't pass GFP_WAIT to kmalloc() from
 *_maybe_bootmem()

On Fri, 2009-06-12 at 12:22 +0300, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@...helsinki.fi>
> 
> As slab is initialized much earlier now, we must not pass GFP_WAIT to kmalloc()
> from *_maybe_bootmem() functions; otherwise slab allocators will enable
> interrupts.
> 
> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> ---
> Ben, while we're discussing the slab side of things, can we go ahead and 
> merge this one? It should fix plenty of cases for powerpc.

We can, but it's a plaster... I won't fix it all, and again, what tells
you that things calling alloc_maybe_bootmem() don't do that specifically
-because- they can be called also much later ? (In this case, it's
__init so I'm not going to object, but I still think it's unnecessary if
we fix it properly).

Cheers,
Ben.

>  arch/powerpc/lib/alloc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/lib/alloc.c b/arch/powerpc/lib/alloc.c
> index f53e09c..56b35e3 100644
> --- a/arch/powerpc/lib/alloc.c
> +++ b/arch/powerpc/lib/alloc.c
> @@ -9,7 +9,7 @@
>  void * __init_refok alloc_maybe_bootmem(size_t size, gfp_t mask)
>  {
>  	if (mem_init_done)
> -		return kmalloc(size, mask);
> +		return kmalloc(size, mask & ~__GFP_WAIT);
>  	else
>  		return alloc_bootmem(size);
>  }
> @@ -19,7 +19,7 @@ void * __init_refok zalloc_maybe_bootmem(size_t size, gfp_t mask)
>  	void *p;
>  
>  	if (mem_init_done)
> -		p = kzalloc(size, mask);
> +		p = kzalloc(size, mask & ~__GFP_WAIT);
>  	else {
>  		p = alloc_bootmem(size);
>  		if (p)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/