| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090612101300.GC29236@buzzloop.caiaq.de> Date: Fri, 12 Jun 2009 12:13:00 +0200 From: Daniel Mack <daniel@...aq.de> To: Pavel Machek <pavel@....cz> Cc: linux-kernel@...r.kernel.org, Eric Piel <eric.piel@...mplin-utc.net> Subject: Re: [PATCH] lis3: add click function On Thu, Jun 11, 2009 at 11:07:55PM +0200, Pavel Machek wrote: > > The LIS3 accelerometer chip has a 'click' feature which can be used to > > detect sudden motion on any of the three axis. Configuration data is > > passed via spi platform_data and no action is taken if that's not > > specified, so it won't harm any existing platform. > > > > To make the configuration effective, the IRQ lines need to be set up > > appropriately. This patch also adds a way to do that from board support > > code. > > > > The DD_* definitions were removed because I couldn't find any reference > > of them in the datasheet and the overlapped with the CLICK_ register > > space. > > > > Signed-off-by: Daniel Mack <daniel@...aq.de> > > Cc: Pavel Machek <pavel@....cz> > > Cc: Eric Piel <eric.piel@...mplin-utc.net> > > Well, patch looks mostly okay, but it would be nice to separate > cleanups onto separate patch... Yes, I've seen that, but considered the two minor things too small to deserve a seperate patch. Do you want me resend? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists