linux-kernel - Re: [PATCH] tty: fix unused warning when TCGETX is not defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090612113320.73e6f7f1@lxorguk.ukuu.org.uk>
Date:	Fri, 12 Jun 2009 11:33:20 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: fix unused warning when TCGETX is not defined

On Fri, 12 Jun 2009 06:27:48 -0400
Mike Frysinger <vapier@...too.org> wrote:

> If TCGETX is not defined, we end up with this warning:
> drivers/char/tty_ioctl.c: In function ‘tty_mode_ioctl’:
> drivers/char/tty_ioctl.c:950: warning: unused variable ‘ktermx’
> 
> Since the variable is only used in one case statement, push it down to
> the local case scope.

If I wasn't so nice I'd just make it and the lack of BOTHER definitions
on platforms error. Really there shouldn't be anyone without the features
defined ;)

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/