linux-kernel - Re: [PATCH] lis3: add click function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090612125550.GF29236@buzzloop.caiaq.de>
Date:	Fri, 12 Jun 2009 14:55:51 +0200
From:	Daniel Mack <daniel@...aq.de>
To:	Éric Piel <eric.piel@...mplin-utc.net>
Cc:	LKML <linux-kernel@...r.kernel.org>, Pavel Machek <pavel@....cz>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] lis3: add click function

On Fri, Jun 12, 2009 at 02:50:08PM +0200, Éric Piel wrote:
> > static struct spi_board_info my_spi_devices[] __initdata = {
> >         {
> >                 .modalias       = "lis3lv02d_spi",
> >                 .max_speed_hz   = 1000000,
> >                 .bus_num        = 0,
> >                 .chip_select    = 0,
> >                 .controller_data = (void *) mfp_to_gpio(GPIO_ACCEL_CS),
> >                 .platform_data  = &lis3_pdata,
> >                 .irq            = gpio_to_irq(mfp_to_gpio(GPIO_ACCEL_IRQ)),
> >         },
> > 
> I see. So your platform is not among the one contained in the vanilla
> kernel? Shouldn't this above code be written somewhere so that people
> know about it? Some of the values do not seem especially obvious!

The platform is currently under development and will be merged at some
later point. The magics above are just GPIO defintions - everything
else is just the usual glue logic you add when registering an SPI
device.

> > We're using the IRQ outputs of that chips directly as source to other
> > circuity, so there is no userspace logic in the game. If anyone needs
> > that, a simple callback function would be easy to add at some later
> > point.
> I guess that to have the functionality in ACPI, a complete handling of
> the interruptions, up to the generation of button events would be
> needed. This can be done later on, whenever someone finds the need...

Ack.

> Acked-by: Eric Piel <eric.piel@...mplin-utc.net>

Thanks :)

Andrew, could you queue that one?

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/