linux-kernel - Re: [PATCH] scripts/checksyscalls.sh: only whine perf_counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090612155641.GB26644@elte.hu>
Date:	Fri, 12 Jun 2009 17:56:41 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Mike Frysinger <vapier.adi@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] scripts/checksyscalls.sh: only whine perf_counter_open
	when supported

* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > > On Fri, Jun 12, 2009 at 09:09, Ingo Molnar wrote:
> > > > * Mike Frysinger <vapier.adi@...il.com> wrote:
> > > >> On Fri, Jun 12, 2009 at 08:59, Ingo Molnar wrote:
> > > >> > * Mike Frysinger <vapier.adi@...il.com> wrote:
> > > >> >> On Fri, Jun 12, 2009 at 08:31, Ingo Molnar wrote:
> > > >> >> > * Mike Frysinger <vapier.adi@...il.com> wrote:
> > > >> >> >> On Fri, Jun 12, 2009 at 08:17, Ingo Molnar wrote:
> > > >> >> >> > * Mike Frysinger <vapier.adi@...il.com> wrote:
> > > >> >> >> >> On Fri, Jun 12, 2009 at 08:05, Ingo Molnar wrote:
> > > >> >> >> >> > * Mike Frysinger <vapier@...too.org> wrote:
> >
> 
> > Anyway, i have no time to teach you about kernel mainteinance basics 
> > really so i probably wont follow up on future emails.
> 
> So yet again you resort to personal attacks when someone objects to the
> world according to Ingo. [...]

You snipped out the proper context. The thing i object to above was 
a technically completely unacceptable solution proposed by Mike:

|  #ifndef __NR_perf_counter_open
|  # error sorry, your arch has not hooked up perf_counter_open syscall yet
|  #endif
|
| is completely unacceptable. We dont propagate build failures via 
| user-enable config options, we never did. There's a lot of people 
| doing randconfig builds - if it randomly failed due to your 'fix' 
| that would upset a lot of testing for no good reason.

and that opinion still holds. (If you disagree then go try to push 
such a solution upstream, and please share with me the various 
replies you will get, it will be an entertaining read.)

Mike made valid technical points later on though and i replied to 
them and accepted most of them. We can certainly annotate out that 
warning message from scripts/checksyscalls.sh.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/