linux-kernel - Re: mthca double free irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada4oul1ksf.fsf@cisco.com>
Date:	Fri, 12 Jun 2009 09:25:36 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Jesse Barnes <jesse.barnes@...el.com>
Cc:	Yinghai Lu <yhlu.kernel@...il.com>,
	Matthew Wilcox <matthew@....cx>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	"general\@lists.openfabrics.org" <general@...ts.openfabrics.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: mthca double free irqs


 > My linux-next branch has a change to the return value from the MSI-X
 > allocation function: pci_enable_msix now returns the number of
 > available entries rather than -EINVAL if the allocation failed.  Would
 > that cause problems in the mthca driver?

I don't think so in this case ... the driver is getting past enabling
MSI-X and actually testing the interrupt before it fails.  I'll audit
the code just to make sure we handle that case though.  But I thought
pci_enable_msix() always returned the number of entries actually
available if the allocation failed?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/