linux-kernel - Re: boot panic with memcg enabled (Was [PATCH 3/4] memcg: don't use bootmem allocator in setup code)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Jun 2009 12:44:08 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	Li Zefan <lizf@...fujitsu.com>,
	Pekka J Enberg <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org, mingo@...e.hu, hannes@...xchg.org,
	torvalds@...ux-foundation.org, yinghai@...nel.org,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: boot panic with memcg enabled (Was [PATCH 3/4] memcg: don't use
 bootmem allocator in setup code)

On Fri, 12 Jun 2009 11:55:01 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:

> On Fri, 12 Jun 2009 10:50:00 +0800
> Li Zefan <lizf@...fujitsu.com> wrote:
> 
> > (This patch should have CCed memcg maitainers)
> > 
> > My box failed to boot due to initialization failure of page_cgroup, and
> > it's caused by this patch:
> > 
> > +	page = alloc_pages_node(nid, GFP_NOWAIT | __GFP_ZERO, order);
> > 
> 
> Oh, I don't know this patch ;(
> 
> > I added a printk, and found that order == 11 == MAX_ORDER.
> > 
> maybe possible because this allocates countinous pages of 60%? length of
> memmap. 
> If __alloc_bootmem_node_nopanic() is not available any more, memcg should be
> only used under CONFIG_SPARSEMEM. 
> 
> Is that a request from bootmem maintainer ?
> 
In other words,
 - Is there any replacment function to allocate continuous pages bigger
   than MAX_ORDER ?
 - If not, memcg (and io-controller under development) shouldn't support
   memory model other than SPARSEMEM.

IIUC, page_cgroup_init() is called before mem_init() and we could use
alloc_bootmem() here.

Could someone teach me which thread should I read to know
"why alloc_bootmem() is gone ?" ?

Thanks,
-Kame

> Thanks,
> -Kame
> 
> 
> > Pekka J Enberg wrote:
> > > From: Yinghai Lu <yinghai@...nel.org>
> > > 
> > > The bootmem allocator is no longer available for page_cgroup_init() because we
> > > set up the kernel slab allocator much earlier now.
> > > 
> > > Cc: Ingo Molnar <mingo@...e.hu>
> > > Cc: Johannes Weiner <hannes@...xchg.org>
> > > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > > Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> > > Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> > > ---
> > >  mm/page_cgroup.c |   12 ++++++++----
> > >  1 files changed, 8 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
> > > index 791905c..3dd4a90 100644
> > > --- a/mm/page_cgroup.c
> > > +++ b/mm/page_cgroup.c
> > > @@ -47,6 +47,8 @@ static int __init alloc_node_page_cgroup(int nid)
> > >  	struct page_cgroup *base, *pc;
> > >  	unsigned long table_size;
> > >  	unsigned long start_pfn, nr_pages, index;
> > > +	struct page *page;
> > > +	unsigned int order;
> > >  
> > >  	start_pfn = NODE_DATA(nid)->node_start_pfn;
> > >  	nr_pages = NODE_DATA(nid)->node_spanned_pages;
> > > @@ -55,11 +57,13 @@ static int __init alloc_node_page_cgroup(int nid)
> > >  		return 0;
> > >  
> > >  	table_size = sizeof(struct page_cgroup) * nr_pages;
> > > -
> > > -	base = __alloc_bootmem_node_nopanic(NODE_DATA(nid),
> > > -			table_size, PAGE_SIZE, __pa(MAX_DMA_ADDRESS));
> > > -	if (!base)
> > > +	order = get_order(table_size);
> > > +	page = alloc_pages_node(nid, GFP_NOWAIT | __GFP_ZERO, order);
> > > +	if (!page)
> > > +		page = alloc_pages_node(-1, GFP_NOWAIT | __GFP_ZERO, order);
> > > +	if (!page)
> > >  		return -ENOMEM;
> > > +	base = page_address(page);
> > >  	for (index = 0; index < nr_pages; index++) {
> > >  		pc = base + index;
> > >  		__init_page_cgroup(pc, start_pfn + index);
> > 
> > 
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/