[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090613134328.0c168205@mjolnir.ossman.eu>
Date: Sat, 13 Jun 2009 13:43:28 +0200
From: Pierre Ossman <pierre@...man.eu>
To: Harald Welte <HaraldWelte@...tech.com>
Cc: Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
JosephChan@....com.tw, Bruce Chang <BruceChang@....com.tw>
Subject: Re: [PATCH] mmc: Add new via-sdmmc host controller driver
On Fri, 12 Jun 2009 15:59:30 +0800
Harald Welte <HaraldWelte@...tech.com> wrote:
> +
> +#define MMC_STOP_TRANSMISSION 12
This define is no longer used.
> + /* It seems that our DMA can not work normally with 375kHz clock */
> + /* FIXME: don't brute-force 8MHz but use PIO at 375kHz !! */
> + addrbase = host->pcictrl_mmiobase;
> + if (readb(addrbase + VIA_CRDR_PCISDCCLK) == PCI_CLK_375K) {
> + dev_info(host->mmc->parent, "forcing card speed to 8MHz\n");
> + writeb(PCI_CLK_8M, addrbase + VIA_CRDR_PCISDCCLK);
> + }
This is pretty nasty. Please see if you can provide a workaround some
time soon.
> + if (ios->power_mode != MMC_POWER_OFF)
> + via_sdc_set_power(host, ios->vdd);
What if we actually do need to power off?
> +static void __devexit via_sd_remove(struct pci_dev *pcidev)
> +{
> + struct via_crdr_mmc_host *sdhost;
> + u8 gatt;
> +
> + pr_info(DRV_NAME
> + ": VIA SDMMC controller at %s [%04x:%04x] has been removed\n",
> + pci_name(pcidev), (int)pcidev->vendor, (int)pcidev->device);
> +
> + sdhost = pci_get_drvdata(pcidev);
> +
> + tasklet_kill(&sdhost->finish_tasklet);
> +
> + if (&sdhost->timer)
> + del_timer_sync(&sdhost->timer);
> +
> + mmc_remove_host(sdhost->mmc);
> +
You need to do the removal as the first step and you might need to
explicitly kill any ongoing requests.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)
Powered by blists - more mailing lists