linux-kernel - Re: [PULL] module and parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Jun 2009 21:35:31 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Tony Luck <tony.luck@...el.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Amerigo Wang <amwang@...hat.com>,
	alex@...rk-linux.de, David Miller <davem@...emloft.net>,
	rth@...ddle.net, sfr@...b.auug.org.au
Subject: Re: [PULL] module and parameter

On Sat, 13 Jun 2009 02:50:15 pm Rusty Russell wrote:
> On Sat, 13 Jun 2009 06:35:46 am Tony Luck wrote:
> > On Fri, Jun 12, 2009 at 5:35 AM, Rusty Russell<rusty@...tcorp.com.au> wrote:
> > >      module: trim exception table on init free.
> >
> > This is causing build errors for ia64:

Unfortunately this has gone into Linus' tree already.  I have compile-tested
my previous patch for ia64, and it fixes compile at least.

> > I note that this commit has been reverted in linux-next.  What's going
> > on?

kisskb.ellerman.id.au says it's broken there, so it's applied.

While I've got your attention, there was another build break on ia64 in
linux-next, caused by removal of smp_call_function_mask.

Thanks,
Rusty.

Subject: ia64: convert last user of smp_call_function_mask

smp_call_function_many is the new version: it takes a pointer.  Also,
use mm accessor macro while we're changing this.

Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

diff --git a/arch/ia64/kernel/smp.c b/arch/ia64/kernel/smp.c
--- a/arch/ia64/kernel/smp.c
+++ b/arch/ia64/kernel/smp.c
@@ -301,7 +301,7 @@ smp_flush_tlb_mm (struct mm_struct *mm)
 		return;
 	}
 
-	smp_call_function_mask(mm->cpu_vm_mask,
+	smp_call_function_many(mm_cpumask(mm),
 		(void (*)(void *))local_finish_flush_tlb_mm, mm, 1);
 	local_irq_disable();
 	local_finish_flush_tlb_mm(mm);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/