linux-kernel - Re: [PATCH 1/2] perfcounters: Print the filename:line for annotated colored lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090613152644.GA4911@nowhere>
Date:	Sat, 13 Jun 2009 17:26:46 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH 1/2] perfcounters: Print the filename:line for
	annotated colored lines

On Sat, Jun 13, 2009 at 05:25:31PM +0200, Frederic Weisbecker wrote:
> When we have a colored line in perf annotate, ie a middle/high
> overhead one, it's sometimes useful to get the matching line
> and filename from the source file, especially this path prepares
> to another subsequent one which will print a sorted summary of
> midle/high overhead lines in the beginning of the output.
> 
> Filename:Lines have the same color than the concerned ip lines.
> 
> It can be slow because it relies on addr2line. We could also
> use objdump with -l but that implies we would have to bufferize
> objdump output and parse it to filter the relevant lines since
> we want to print a sorted summary in the beginning.
> 
> Changes in v2:
> - fix addr2line on userspace binary
> - fix string allocation size (missing ending null char room)
> - fix overflow in symbol extra info
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>


Forgot to put "v2" in the [PATCH] token. It fixes what you reported
Ingo, and also some other things.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/