| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <86802c440906131228y6365f23fi59cd04f381fe92fc@mail.gmail.com>
Date: Sat, 13 Jun 2009 12:28:29 -0700
From: Yinghai Lu <yhlu.kernel@...il.com>
To: Roland Dreier <rdreier@...co.com>
Cc: "Barnes, Jesse" <jesse.barnes@...el.com>,
Matthew Wilcox <matthew@....cx>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...e.hu>, general@...ts.openfabrics.org,
linux-kernel@...r.kernel.org
Subject: Re: mthca double free irqs
On Fri, Jun 12, 2009 at 9:30 PM, Roland Dreier<rdreier@...co.com> wrote:
> Something like this should help -- can you verify this fixes the double
> free of irq?
>
> drivers/infiniband/hw/mthca/mthca_eq.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mthca/mthca_eq.c b/drivers/infiniband/hw/mthca/mthca_eq.c
> index 28f0e0c..90e4e45 100644
> --- a/drivers/infiniband/hw/mthca/mthca_eq.c
> +++ b/drivers/infiniband/hw/mthca/mthca_eq.c
> @@ -641,9 +641,11 @@ static void mthca_free_irqs(struct mthca_dev *dev)
> if (dev->eq_table.have_irq)
> free_irq(dev->pdev->irq, dev);
> for (i = 0; i < MTHCA_NUM_EQ; ++i)
> - if (dev->eq_table.eq[i].have_irq)
> + if (dev->eq_table.eq[i].have_irq) {
> free_irq(dev->eq_table.eq[i].msi_x_vector,
> dev->eq_table.eq + i);
> + dev->eq_table.eq[i].have_irq = 0;
> + }
> }
>
> static int mthca_map_reg(struct mthca_dev *dev,
>
thanks, that fixes the problem.
got
[ 688.153102] ib_mthca: Mellanox InfiniBand HCA driver v1.0 (April 4, 2008)
[ 688.164128] ib_mthca: Initializing 0000:c4:00.0
[ 688.170696] ib_mthca 0000:c4:00.0: PCI INT A -> GSI 98 (level, low) -> IRQ 98
[ 688.184033] ib_mthca 0000:c4:00.0: setting latency timer to 64
[ 688.188594] ib_mthca 0000:c4:00.0: using 64bit DMA mask
[ 688.208718] ib_mthca 0000:c4:00.0: using 64bit consistent DMA mask
[ 688.217191] reserve_memtype added 0xfbef0000-0xfbef1000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 688.232259] free_memtype request 0xfbef0000-0xfbef1000
[ 689.243254] reserve_memtype added 0xfbe80000-0xfbe81000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 689.537336] reserve_memtype added 0xfa800000-0xfa801000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 689.587286] ib_mthca 0000:c4:00.0: HCA FW version 4.7.400 is old
(4.8.200 is current).
[ 689.592067] ib_mthca 0000:c4:00.0: If you have problems, try
updating your HCA FW.
[ 689.603264] reserve_memtype added 0xfbe82000-0xfbe83000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 689.622765] alloc irq_desc for 230 on node 0
[ 689.629521] alloc kstat_irqs on node 0
[ 689.641401] ib_mthca 0000:c4:00.0: irq 230 for MSI/MSI-X
[ 689.645155] alloc irq_desc for 231 on node 0
[ 689.647072] alloc kstat_irqs on node 0
[ 689.663348] ib_mthca 0000:c4:00.0: irq 231 for MSI/MSI-X
[ 689.666000] alloc irq_desc for 232 on node 0
[ 689.682655] alloc kstat_irqs on node 0
[ 689.685768] ib_mthca 0000:c4:00.0: irq 232 for MSI/MSI-X
[ 689.701511] reserve_memtype added 0xfa802000-0xfa803000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 689.721752] reserve_memtype added 0xe5800000-0xe6000000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 689.731141] reserve_memtype added 0xe0000000-0xe4000000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 689.753919] reserve_memtype added 0xfbef0000-0xfbef1000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 689.770375] Overlap at 0xfbe80000-0xfbe81000
[ 689.782317] reserve_memtype added 0xfbe80000-0xfbe81000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 689.902837] ib_mthca 0000:c4:00.0: NOP command failed to generate
interrupt (IRQ 232).
[ 689.907900] ib_mthca 0000:c4:00.0: Trying again with MSI-X disabled.
[ 689.923292] free_memtype request 0xfbe80000-0xfbe81000
[ 689.926430] free_memtype request 0xfbef0000-0xfbef1000
[ 689.942964] free_memtype request 0xe0000000-0xe4000000
[ 689.947059] free_memtype request 0xe5800000-0xe6000000
[ 689.962869] free_memtype request 0xfa802000-0xfa803000
[ 689.967293] free_memtype request 0xfbe82000-0xfbe83000
[ 689.980961] reserve_memtype added 0xfa802000-0xfa803000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 690.003659] reserve_memtype added 0xe5800000-0xe6000000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 690.015144] reserve_memtype added 0xe0000000-0xe4000000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 690.033814] reserve_memtype added 0xfbef0000-0xfbef1000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 690.046945] Overlap at 0xfbe80000-0xfbe81000
[ 690.062803] reserve_memtype added 0xfbe80000-0xfbe81000, track
uncached-minus, req uncached-minus, ret uncached-minus
[ 690.182718] ib_mthca 0000:c4:00.0: NOP command failed to generate
interrupt (IRQ 98), aborting.
[ 690.188676] ib_mthca 0000:c4:00.0: BIOS or ACPI interrupt routing problem?
[ 690.203724] free_memtype request 0xfbe80000-0xfbe81000
[ 690.205768] free_memtype request 0xfbef0000-0xfbef1000
[ 690.224080] free_memtype request 0xe0000000-0xe4000000
[ 690.228558] free_memtype request 0xe5800000-0xe6000000
[ 690.241523] free_memtype request 0xfa802000-0xfa803000
[ 690.246196] free_memtype request 0xfbe80000-0xfbe81000
[ 690.263133] free_memtype request 0xfa800000-0xfa801000
[ 690.268628] ib_mthca 0000:c4:00.0: PCI INT A disabled
[ 690.281553] ib_mthca: probe of 0000:c4:00.0 failed with error -16
as expected.
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists