linux-kernel - Re: 2.6.31 -mm merge plans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1ski3n9dh.fsf@fess.ebiederm.org>
Date:	Sat, 13 Jun 2009 13:53:30 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Amerigo Wang <amwang@...hat.com>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: 2.6.31 -mm merge plans

Amerigo Wang <amwang@...hat.com> writes:

> Al Viro wrote:
>> On Thu, Jun 11, 2009 at 09:15:05AM +0800, Amerigo Wang wrote:
>>   
>>> Hi, Al.
>>>
>>> Just as what I said in the description of that patch, one only has  extern
>>> functions that are _only_ used in another as function pointers.
>>>     
>>
>> Er...  So what?  Amount of functions made static is not, per se, a
>> useful metrics of anything.
>>   
> Not only about static, but also because they are used via function pointers.
>
> Logically, it is better for these functions used via pointers to be kept in
> the same file with the struct which holds these function pointers.

I am going to agree with Al here.  array.c has a well defined function
and purpose.  base.c is on it's way to becoming a dumping ground.  The
only reason the functions in array.c are used directly in base.c is
that we don't have a way to dynamically register struct pid_entry's.

Given the number of ifdefs in base.c it looks like it could really benefit
from splitting up.   I made it about half way there last time I was working
on proc.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/