linux-kernel - Re: [PATCH 05/27] score: create head files cache.h cacheflush.h checksum.h cputime.h current.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Jun 2009 14:33:38 +0800
From:	liqin.chen@...plusct.com
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH 05/27] score: create head files cache.h cacheflush.h checksum.h
 cputime.h current.h

Hi Arnd,

Arnd Bergmann <arnd@...db.de> 写于 2009-06-10 01:07:16:

> On Tuesday 09 June 2009, liqin.chen@...plusct.com wrote:
> > diff --git a/arch/score/include/asm/cacheflush.h 
> > b/arch/score/include/asm/cacheflush.h
> > +extern void (*flush_cache_all)(void);
> > +extern void (*flush_cache_mm)(struct mm_struct *mm);
> > +extern void (*flush_cache_range)(struct vm_area_struct *vma,
> > +                               unsigned long start, unsigned long 
end);
> > +extern void (*flush_cache_page)(struct vm_area_struct *vma,
> > +                               unsigned long page, unsigned long 
pfn);
> > +extern void (*flush_cache_sigtramp)(unsigned long addr);
> > +extern void (*flush_icache_all)(void);
> > +extern void (*flush_icache_range)(unsigned long start, unsigned long 
> > end);
> > +extern void (*flush_data_cache_page)(unsigned long addr);
> 
> This is a somewhat unusual way to express these functions. It seems
> that you only have one implementation for each of them, so I wonder
> why you keep them as function pointers. Do you plan to add more CPUs
> in the future that do these differently?
> 

S+core series have score7 core and score3 core, they use different ISA,
this patch only include score7 code. We will provide score3 code latter.

> > --- /dev/null
> > +++ b/arch/score/include/asm/current.h
> > @@ -0,0 +1,15 @@
> > +#ifndef _ASM_SCORE_CURRENT_H
> > +#define _ASM_SCORE_CURRENT_H
> > +
> > +#include <linux/thread_info.h>
> > +
> > +struct task_struct;
> > +
> > +static inline struct task_struct *get_current(void)
> > +{
> > +       return current_thread_info()->task;
> > +}
> > +
> > +#define current        get_current()
> > +
> > +#endif /* _ASM_SCORE_CURRENT_H */
> 
> This is basically the asm-generic version, so you could just use that
> instead.
> 

Use asm-generic/current.h instead.

Best Regards
Liqin
--